Add Submodules with simpler APIs to Pp_ast #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanReb
requested review from
ceastlund,
panglesd,
patricoferris and
pitag-ha
as code owners
NathanReb
force-pushed
the
better-pp-ast-api
branch
from
7575f10
to
f5e1eab
Compare
patricoferris
approved these changes
Nov 15, 2024
|
Yes that sounds like a good idea! I'll factor out the pretty-printer type! I'll go ahead and make the test suite 5.3 compatible first though! |
NathanReb
force-pushed
the
better-pp-ast-api
branch
from
f5e1eab
to
1385740
Compare
|
I pushed the changes with the new alias types. I didn't go for |
Signed-off-by: Nathan Rebours <[email protected]>
Signed-off-by: Nathan Rebours <[email protected]>
NathanReb
force-pushed
the
better-pp-ast-api
branch
from
1385740
to
9129e81
Compare
|
@NathanReb did you mean to reply to #338 ? (your comment makes more sense to me in the context of this other issue) |
patricoferris
approved these changes
Nov 26, 2024
Indeed! My bad, I'll move the message! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a functor and a
Defaultmodule, similar to what's done inAst_builder. One can use the functor to get pre-configured formatters or use the formatters provided by theDefaultmodule which are preconfigured with the default configuration.This provides modules whose pretty printers can be used directly with
"%a"format strings as they don't expect an optional argument first.